Fix volume adjust key repeat not working as expected #31282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
requested changes
Dec 26, 2024
Comment on lines
+1433
to
+1435
| case GlobalAction.DecreaseVolume: | ||
| case GlobalAction.IncreaseVolume: | ||
| return volume.Adjust(e.Action); |
There was a problem hiding this comment.
why is this block duplicated now? another copy of it is still there lower down
Lines 1447 to 1449 in e752531
There was a problem hiding this comment.
Oversight from lack of self checks for sure
bdach
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regressed in #31146.
Closes part of #31267.
We don't have an easy way to test key repeat in tests unfortunately.